[
https://issues.apache.org/jira/browse/FLINK-7410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147389#comment-16147389
]
ASF GitHub Bot commented on FLINK-7410:
---------------------------------------
GitHub user hequn8128 opened a pull request:
https://github.com/apache/flink/pull/4624
[FLINK-7410] [table] Use toString method to display operator names for
UserDefinedFunction
## What is the purpose of the change
*Use toString method to display operator names for UserDefinedFunction. The
method will return class name by default. Users can also override the method to
return whatever he wants*
## Brief change log
- *Add `toString` method to `UserDefinedFunction ` and returns class name
by default*
- *Override `toString` method in `AggSqlFunction `, `ScalarSqlFunction `
and `TableSqlFunction ` to return class name*
- *Modify test cases*
## Verifying this change
This change added tests and can be verified as follows:
- *Modify CalcTest/CorrelateTest/AggTest to validate that operator names
are displayed correctly*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hequn8128/flink 7410
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4624.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4624
----
commit 561cc61ddd9a3d049fcf84e2e4e2334d436c6ca6
Author: 军长 <hequn....@alibaba-inc.com>
Date: 2017-08-30T11:30:52Z
[FLINK-7410] [table] Use toString method to display operator names for
UserDefinedFunction
----
> Use toString method to display operator names for UserDefinedFunction
> ---------------------------------------------------------------------
>
> Key: FLINK-7410
> URL: https://issues.apache.org/jira/browse/FLINK-7410
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.4.0
> Reporter: Hequn Cheng
> Assignee: Hequn Cheng
>
> *Motivation*
> Operator names setted in table-api are used by visualization and logging, it
> is import to make these names simple and readable. Currently,
> UserDefinedFunction’s name contains class CanonicalName and md5 value making
> the name too long and unfriendly to users.
> As shown in the following example,
> {quote}
> select: (a, b, c,
> org$apache$flink$table$expressions$utils$RichFunc1$281f7e61ec5d8da894f5783e2e17a4f5(a)
> AS _c3,
> org$apache$flink$table$expressions$utils$RichFunc2$fb99077e565685ebc5f48b27edc14d98(c)
> AS _c4)
> {quote}
> *Changes:*
>
> Use {{toString}} method to display operator names for UserDefinedFunction.
> The method will return class name by default. Users can also override the
> method to return whatever he wants.
> What do you think [~fhueske] ?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
