[ 
https://issues.apache.org/jira/browse/FLINK-7068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155566#comment-16155566
 ] 

ASF GitHub Bot commented on FLINK-7068:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4358#discussion_r137262572
  
    --- Diff: 
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/TaskManagerLogHandler.java
 ---
    @@ -158,7 +151,7 @@ protected void respondAsLeader(final 
ChannelHandlerContext ctx, final Routed rou
                        cache = blobPortFuture.thenApplyAsync(
                                (Integer port) -> {
                                        try {
    -                                           return new BlobCache(new 
InetSocketAddress(jobManagerGateway.getHostname(), port), config, blobView);
    +                                           return new 
TransientBlobCache(new InetSocketAddress(jobManagerGateway.getHostname(), 
port), config);
                                        } catch (IOException e) {
                                                throw new 
FlinkFutureException("Could not create BlobCache.", e);
    --- End diff --
    
    Maybe we could adapt the exception message to `TransientBlobCache`.


> change BlobService sub-classes for permanent and transient BLOBs
> ----------------------------------------------------------------
>
>                 Key: FLINK-7068
>                 URL: https://issues.apache.org/jira/browse/FLINK-7068
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination, Network
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>
> A {{PermanentBlobStore}} should resemble use cases for BLOBs that are 
> permanently stored for a job's life time (HA and non-HA).
> A {{TransientBlobStore}} should reflect BLOB offloading for logs, RPC, etc. 
> which even does not have to be reflected by files.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to