[GitHub] flink pull request #4358: [FLINK-7068][blob] change BlobService sub-classes ...

[tillrohrmann]

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4358#discussion_r137302842
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java ---
    @@ -174,7 +176,6 @@ public ServerSocket createSocket(int port) throws 
IOException {
                // start the server thread
                setName("BLOB Server listener at " + getPort());
                setDaemon(true);
    -           start();
    --- End diff --
    
    Why did you pull `start` out of the constructor? Wouldn't one always want 
to start the `BlobServer` when creating it?


---