[
https://issues.apache.org/jira/browse/FLINK-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165962#comment-16165962
]
Jin Xiaojun commented on FLINK-7617:
------------------------------------
hi, [~lzljs3620320], I think a better is to call Preconditions.checkArgument
with errorMeesageTemplate and errorMessageArgs
{code:java}
public static void checkArgument(boolean condition,
@Nullable String errorMessageTemplate,
@Nullable Object... errorMessageArgs) {
if (!condition) {
throw new IllegalArgumentException(format(errorMessageTemplate,
errorMessageArgs));
}
}
{code}
Do you think so? :) Thanks~
> Remove string format in BitSet to improve the performance of
> BuildSideOuterjoin
> -------------------------------------------------------------------------------
>
> Key: FLINK-7617
> URL: https://issues.apache.org/jira/browse/FLINK-7617
> Project: Flink
> Issue Type: Improvement
> Components: Local Runtime
> Reporter: Jingsong Lee
>
> When using BuildSideOuterjoin, will frequently call Bitset.set and get, there
> will be
> Preconditions.checkArgument (index <bitLength && index> = 0,
> String.format ("Input Index [% d] is larger than BitSet available size [%
> d].", Index, bitLength));
> Of the check, String.format will lead to a sharp decline performance.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
