[
https://issues.apache.org/jira/browse/FLINK-7394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167588#comment-16167588
]
ASF GitHub Bot commented on FLINK-7394:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4499#discussion_r138915958
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -72,6 +79,21 @@
*/
private int expectedSequenceNumber = 0;
+ /** The initial number of exclusive buffers assigned to this channel. */
+ private int initialCredit;
+
+ /** The current available exclusive buffers and requested floating
buffers from buffer pool. */
+ private final Queue<Buffer> availableBuffers = new ArrayDeque<>();
+
+ /** The number of available buffers that have not unannounced to
producer yet. */
+ private final AtomicInteger unannouncedCredit = new AtomicInteger(0);
+
+ /** The number of unsent buffers in producer's sub partition. */
+ private final AtomicInteger currentSenderBacklog = new AtomicInteger(0);
--- End diff --
you could probably simplify the name to `senderBacklog`
> Implement basic InputChannel for credit-based logic
> ---------------------------------------------------
>
> Key: FLINK-7394
> URL: https://issues.apache.org/jira/browse/FLINK-7394
> Project: Flink
> Issue Type: Sub-task
> Components: Core
> Reporter: zhijiang
> Assignee: zhijiang
> Fix For: 1.4.0
>
>
> This is a part of work for credit-based network flow control.
> The basic works are:
> * Propose the {{BufferListener}} interface for notifying buffer availability
> and buffer destroyed.
> * {{RemoteInputChannel}} implements {{BufferRecycler}} interface to manage
> the exclusive buffers itself.
> * {{RemoteInputChannel}} implements {{BufferListener}} interface to be
> notified repeatedly .
> * {{RemoteInputChannel}} maintains and notifies of unannounced credit.
> * {{RemoteInputChannel}} maintains current sender backlog to trigger requests
> of floating buffers.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
