[ 
https://issues.apache.org/jira/browse/FLINK-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169178#comment-16169178
 ] 

ASF GitHub Bot commented on FLINK-5859:
---------------------------------------

Github user godfreyhe commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4667#discussion_r139300836
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/FilterableTableSource.scala
 ---
    @@ -55,4 +55,9 @@ trait FilterableTableSource[T] {
         */
       def isFilterPushedDown: Boolean
     
    +  /**
    +    * @param relBuilder Builder for relational expressions.
    +    */
    +  def setRelBuilder(relBuilder: RelBuilder): Unit
    --- End diff --
    
    `setRelBuilder` method is called in `PushFilterIntoTableSourceScanRule`. If 
we move  `setRelBuilder` method to `PartitionableTableSource`,  
`PushFilterIntoTableSourceScanRule` should know `FilterableTableSource` and 
`PartitionableTableSource` both.


> support partition pruning on Table API & SQL
> --------------------------------------------
>
>                 Key: FLINK-5859
>                 URL: https://issues.apache.org/jira/browse/FLINK-5859
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: godfrey he
>            Assignee: godfrey he
>
> Many data sources are partitionable storage, e.g. HDFS, Druid. And many 
> queries just need to read a small subset of the total data. We can use 
> partition information to prune or skip over files irrelevant to the user’s 
> queries. Both query optimization time and execution time can be reduced 
> obviously, especially for a large partitioned table.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to