Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3511#discussion_r140258675
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/NormalizedKeySorter.java
 ---
    @@ -47,61 +47,61 @@
        
        public static final int MAX_NORMALIZED_KEY_LEN_PER_ELEMENT = 8;
        
    -   private static final int MIN_REQUIRED_BUFFERS = 3;
    +   public static final int MIN_REQUIRED_BUFFERS = 3;
        
    -   private static final int LARGE_RECORD_THRESHOLD = 10 * 1024 * 1024;
    +   public static final int LARGE_RECORD_THRESHOLD = 10 * 1024 * 1024;
        
    -   private static final long LARGE_RECORD_TAG = 1L << 63;
    +   public static final long LARGE_RECORD_TAG = 1L << 63;
        
    -   private static final long POINTER_MASK = LARGE_RECORD_TAG - 1;
    +   public static final long POINTER_MASK = LARGE_RECORD_TAG - 1;
     
    --- End diff --
    
    Maybe put that into the comment inside the code?


---

Reply via email to