[
https://issues.apache.org/jira/browse/FLINK-7664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16177318#comment-16177318
]
ASF GitHub Bot commented on FLINK-7664:
---------------------------------------
Github user bowenli86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4701#discussion_r140614369
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarPlanHandler.java
---
@@ -65,7 +65,7 @@ public JarPlanHandler(Executor executor, File
jarDirectory) {
return writer.toString();
}
catch (Exception e) {
- throw new FlinkFutureException(e);
+ throw new CompletionException(e);
--- End diff --
Why it's not wrapping a `FlinkException` here?
> Replace FlinkFutureException by CompletionException
> ---------------------------------------------------
>
> Key: FLINK-7664
> URL: https://issues.apache.org/jira/browse/FLINK-7664
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
>
> The {{FlinkFutureException}} was introduced to fail in a
> {{CompletableFuture}} callback. This can, however, better be done via the
> {{CompletionException}}. Therefore, we should remove the
> {{FlinkFutureException}} and replace it with the {{CompletionException}}
> instead.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
