Github user ggevay commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3511#discussion_r140663599
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/TemplateManager.java
 ---
    @@ -0,0 +1,108 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.codegeneration;
    +
    +import freemarker.template.Configuration;
    +import freemarker.template.Template;
    +import freemarker.template.TemplateException;
    +import freemarker.template.TemplateExceptionHandler;
    +
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.io.IOException;
    +import java.io.StringWriter;
    +import java.io.Writer;
    +import java.util.Map;
    +
    +/**
    + * {@link TemplateManager} is a singleton class that provides template 
rendering functionalities for code generation.
    + * Such functionalities are caching, writing generated code to a file.
    --- End diff --
    
    Sorry, you are right, we don't write to a file anymore. Also, the caching 
is not handled by this class anymore (it is handled by `SorterFactory`). So 
I've just realized that this class is not really needed, and moved its 
functionality into `SorterFactory`.
    b8f1e53fa46b0ec7f9b7baefbb388c29be72f7ee


---

Reply via email to