[
https://issues.apache.org/jira/browse/FLINK-7394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179223#comment-16179223
]
ASF GitHub Bot commented on FLINK-7394:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4499#discussion_r140810853
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -99,8 +114,24 @@ public RemoteInputChannel(
this.connectionManager = checkNotNull(connectionManager);
}
+ /**
+ * Assigns exclusive buffers to this input channel, and this method
should be called only once
+ * after this input channel is created.
+ */
void assignExclusiveSegments(List<MemorySegment> segments) {
- // TODO in next PR
+ checkState(this.initialCredit == 0, "Bug in input channel setup
logic: exclusive buffers have" +
+ "already been set for this input channel.");
--- End diff --
please add a space between `have` and `already` (between the concatenations)
> Manage exclusive buffers in RemoteInputChannel
> ----------------------------------------------
>
> Key: FLINK-7394
> URL: https://issues.apache.org/jira/browse/FLINK-7394
> Project: Flink
> Issue Type: Sub-task
> Components: Core
> Reporter: zhijiang
> Assignee: zhijiang
> Fix For: 1.4.0
>
>
> This is a part of work for credit-based network flow control.
> The basic works are:
> * Exclusive buffers are assigned to {{RemoteInputChannel}} after created by
> {{SingleInputGate}}.
> * {{RemoteInputChannel}} implements {{BufferRecycler}} interface to manage
> the exclusive buffers itself.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
