[GitHub] flink pull request #4556: [FLINK-6465][table]support FIRST_VALUE on Table AP...

[haohui]

Github user haohui commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4556#discussion_r140824914
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
 ---
    @@ -1406,6 +1406,61 @@ object AggregateUtil {
                   }
                 }
               }
    +        case sqlFirstLastValueAggFunction: SqlFirstLastValueAggFunction =>
    +
    +          aggregates(index) = if (sqlFirstLastValueAggFunction.getKind == 
SqlKind.FIRST_VALUE) {
    +            if (needRetraction) {
    +              sqlTypeName match {
    --- End diff --
    
    Convert it to a map


---