[ 
https://issues.apache.org/jira/browse/FLINK-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182108#comment-16182108
 ] 

ASF GitHub Bot commented on FLINK-7683:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4722#discussion_r141258536
  
    --- Diff: 
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
 ---
    @@ -1946,4 +1974,44 @@ public File getInstanceBasePath() {
        public boolean supportsAsynchronousSnapshots() {
                return true;
        }
    +
    +   private static class RocksIteratorWrapper<K> implements Iterator<K> {
    +           private final RocksIterator iterator;
    +           private final String field;
    +           private final TypeSerializer<K> keySerializer;
    +           private final int keyGroupPrefixBytes;
    +
    +           public RocksIteratorWrapper(
    +                           RocksIterator iterator,
    +                           String field,
    +                           TypeSerializer<K> keySerializer,
    +                           int keyGroupPrefixBytes) {
    +                   this.iterator = Preconditions.checkNotNull(iterator);
    +                   this.field = Preconditions.checkNotNull(field);
    +                   this.keySerializer = 
Preconditions.checkNotNull(keySerializer);
    +                   this.keyGroupPrefixBytes = 
Preconditions.checkNotNull(keyGroupPrefixBytes);
    +           }
    +
    +           @Override
    +           public boolean hasNext() {
    +                   return iterator.isValid();
    +           }
    +
    +           @Override
    +           public K next() {
    +                   if (!iterator.isValid()) {
    --- End diff --
    
    fixed


> Add method to iterate over all of the existing keys in a statebackend
> ---------------------------------------------------------------------
>
>                 Key: FLINK-7683
>                 URL: https://issues.apache.org/jira/browse/FLINK-7683
>             Project: Flink
>          Issue Type: New Feature
>          Components: State Backends, Checkpointing
>            Reporter: Piotr Nowojski
>            Assignee: Piotr Nowojski
>
> This is required to make possible preserving backward compatibility while 
> changing state definition of a keyed state operator (to do so operator must 
> iterate over all of the existing keys and rewrites them into a new state 
> variable).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to