[ 
https://issues.apache.org/jira/browse/FLINK-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14585727#comment-14585727
 ] 

ASF GitHub Bot commented on FLINK-2152:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/832#discussion_r32405496
  
    --- Diff: 
flink-tests/src/test/java/org/apache/flink/test/util/DataSetUtilsITCase.java ---
    @@ -0,0 +1,71 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.test.util;
    +
    +import org.apache.flink.api.java.DataSet;
    +import org.apache.flink.api.java.ExecutionEnvironment;
    +import org.apache.flink.api.java.tuple.Tuple2;
    +import org.apache.flink.api.java.utils.DataSetUtils;
    +import org.junit.After;
    +import org.junit.Before;
    +import org.junit.Rule;
    +import org.junit.Test;
    +import org.junit.rules.TemporaryFolder;
    +import org.junit.runner.RunWith;
    +import org.junit.runners.Parameterized;
    +
    +@RunWith(Parameterized.class)
    +public class DataSetUtilsITCase extends MultipleProgramsTestBase {
    +
    +   private String resultPath;
    +   private String expectedResult;
    +
    +   @Rule
    +   public TemporaryFolder tempFolder = new TemporaryFolder();
    +
    +   public DataSetUtilsITCase(TestExecutionMode mode) {
    +           super(mode);
    +   }
    +
    +   @Before
    +   public void before() throws Exception{
    +           resultPath = tempFolder.newFile().toURI().toString();
    +   }
    +
    +   @Test
    +   public void testZipWithIndex() throws Exception {
    +           ExecutionEnvironment env = 
ExecutionEnvironment.getExecutionEnvironment();
    +           env.setParallelism(1);
    +           DataSet<String> in = env.fromElements("A", "B", "C", "D", "E", 
"F");
    +
    +           DataSetUtils<String> dataSetUtils = new DataSetUtils<String>();
    --- End diff --
    
    Why do we have to create a `DataSetUtils` object here? So far it does not 
store any state.


> Provide zipWithIndex utility in flink-contrib
> ---------------------------------------------
>
>                 Key: FLINK-2152
>                 URL: https://issues.apache.org/jira/browse/FLINK-2152
>             Project: Flink
>          Issue Type: Improvement
>          Components: Java API
>            Reporter: Robert Metzger
>            Assignee: Andra Lungu
>            Priority: Trivial
>              Labels: starter
>
> We should provide a simple utility method for zipping elements in a data set 
> with a dense index.
> its up for discussion whether we want it directly in the API or if we should 
> provide it only as a utility from {{flink-contrib}}.
> I would put it in {{flink-contrib}}.
> See my answer on SO: 
> http://stackoverflow.com/questions/30596556/zipwithindex-on-apache-flink



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to