Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4735#discussion_r141393650
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ---
    @@ -87,6 +88,12 @@
        /** The number of available buffers that have not been announced to the 
producer yet. */
        private final AtomicInteger unannouncedCredit = new AtomicInteger(0);
     
    +   /** The number of unsent buffers in the producer's sub partition. */
    +   private final AtomicInteger senderBacklog = new AtomicInteger(0);
    +
    +   /** The tag indicates whether this channel is waiting for additional 
floating buffers from the buffer pool. */
    +   private final AtomicBoolean isWaitingFloatingBuffers = new 
AtomicBoolean(false);
    --- End diff --
    
    but in general, do we need this field? For now, I only see this being used 
to verify correct use and I'm not sure whether the costs verify this. Also, 
nothing in this PR sets it to `true`.


---

Reply via email to