[
https://issues.apache.org/jira/browse/FLINK-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182814#comment-16182814
]
ASF GitHub Bot commented on FLINK-7699:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4735#discussion_r141392162
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
---
@@ -313,6 +320,49 @@ public int getNumberOfAvailableBuffers() {
}
}
+ /**
+ * Buffer pool notifies this channel of an available floating buffer.
If the channel is released or not
+ * needing extra buffers currently, the buffer should be recycled to
buffer pool. Otherwise, the buffer
+ * will be added into the available queue and the unannounced credit is
increased by one.
--- End diff --
`The Buffer pool notifies this channel of an available floating buffer. If
the channel is released or currently does not need extra buffers, the buffer
should be recycled to the buffer pool. Otherwise, the buffer will be added into
the <tt>availableBuffers</tt> queue and the unannounced credit is increased by
one.`
> Define the BufferListener interface to replace EventlListener in
> BufferProvider
> -------------------------------------------------------------------------------
>
> Key: FLINK-7699
> URL: https://issues.apache.org/jira/browse/FLINK-7699
> Project: Flink
> Issue Type: Sub-task
> Components: Core
> Reporter: zhijiang
> Assignee: zhijiang
> Fix For: 1.4.0
>
>
> Currently the {{EventListener}} is used in {{BufferProvider}} to be notified
> of buffer available or destroyed pool.
> To be semantic clearly, we define a new {{BufferListener}} interface which
> can opt for a one-time only notification or to be notified repeatedly. And we
> can also notify the pool destroyed via explicitly method
> {{notifyBufferDestroyed}}.
> The {{RemoteInputChannel}} will implement the {{BufferListener}} interface to
> wait for floating buffers from {{BufferProvider}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
