Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/805#discussion_r32415084
  
    --- Diff: 
flink-staging/flink-scala-shell/src/main/scala/org.apache.flink/api/scala/FlinkShell.scala
 ---
    @@ -44,6 +46,16 @@ object FlinkShell {
               c.copy (host = x)
           }  text("host specifies host name of running JobManager")
     
    +      opt[(String)] ('a',"addclasspath") action {
    +        case (x,c) =>
    +          val xArray = x.split(":")
    +          var extJarArray = new Array[String](xArray.length)
    +          for(i <- 0 to xArray.length - 1){
    +            extJarArray(i) = xArray(i)
    +          }
    --- End diff --
    
    Why do you copy `xArray` here? And why not simply calling `xArray.clone`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to