[ https://issues.apache.org/jira/browse/FLINK-7752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16190756#comment-16190756 ]
ASF GitHub Bot commented on FLINK-7752: --------------------------------------- GitHub user EronWright opened a pull request: https://github.com/apache/flink/pull/4766 [FLINK-7752] [flip-6] RedirectHandler should execute on the IO thread ## What is the purpose of the change Improves the determinism of REST handlers by running the response method (`respondAsLeader`) on the I/O thread rather than (potentially) on a thread from the gateway retriever's executor. ## Brief change log - in `RedirectHandler`, upon obtaining the gateway address, run the completion logic using the channel executor. ## Verifying this change This change added tests and can be verified as follows: - updated `RedirectHandlerTest` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive):no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no ## Documentation - Does this pull request introduce a new feature? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/EronWright/flink FLINK-7752 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4766.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4766 ---- commit 5741cf9f4a0f19ec063f92fd3cc2a16c39ce24d7 Author: Wright, Eron <eron.wri...@emc.com> Date: 2017-10-04T03:36:09Z [FLINK-7752] [flip-6] RedirectHandler should execute on the IO thread ---- > RedirectHandler should execute on the IO thread > ----------------------------------------------- > > Key: FLINK-7752 > URL: https://issues.apache.org/jira/browse/FLINK-7752 > Project: Flink > Issue Type: Sub-task > Components: Cluster Management, Mesos > Reporter: Eron Wright > Priority: Minor > > The redirect handler executes much of its logic (including 'respondAsLeader') > on an arbitrary thread, but it would be cleaner to execute on the I/O thread > by using `channelHandlerContext.executor()`. Note that Netty allows writes > on any thread but reads on the I/O thread. -- This message was sent by Atlassian JIRA (v6.4.14#64029)