Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4746#discussion_r142634197
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/TableTestBase.scala
 ---
    @@ -200,10 +201,30 @@ case class BatchTableTestUtil() extends TableTestUtil 
{
         printTable(tableEnv.sqlQuery(query))
       }
     
    +  def verifyExpressionProjection(fields: Seq[(String, TypeInformation[_])],
    --- End diff --
    
    The `TableTestBase` class is intended for general test utilities. This 
looks very specific to me. I would add to to the `TableSourceTest` or a utils 
class there.


---

Reply via email to