[
https://issues.apache.org/jira/browse/FLINK-6615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196502#comment-16196502
]
ASF GitHub Bot commented on FLINK-6615:
---------------------------------------
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/4787
[FLINK-6615] simplify FileUtils
## What is the purpose of the change
simplify FileUtils
## Brief change log
simplify FileUtils
## Verifying this change
This change is already covered by existing tests
## Does this pull request potentially affect one of the following parts:
none
## Documentation
no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bowenli86/flink FLINK-6615
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4787.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4787
----
commit 050e0b724d7d951d3310942c763c261a2691f843
Author: Bowen Li <[email protected]>
Date: 2017-10-09T04:57:46Z
[FLINK-6615] simplify FileUtils
----
> tmp directory not cleaned up on shutdown
> ----------------------------------------
>
> Key: FLINK-6615
> URL: https://issues.apache.org/jira/browse/FLINK-6615
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime
> Affects Versions: 1.2.0
> Reporter: Andrey
> Assignee: Bowen Li
>
> Steps to reproduce:
> 1) Stop task manager gracefully (kill -6 )
> 2) In the logs:
> {code}
> 2017-05-17 13:35:50,147 INFO org.apache.zookeeper.ClientCnxn
> - EventThread shut down [main-EventThread]
> 2017-05-17 13:35:50,200 ERROR
> org.apache.flink.runtime.io.disk.iomanager.IOManager - IOManager
> failed to properly clean up temp file directory:
> /mnt/flink/tmp/flink-io-66f1d0ec-8976-41bf-9575-f80b181b0e47
> [flink-akka.actor.default-dispatcher-2]
> java.nio.file.DirectoryNotEmptyException:
> /mnt/flink/tmp/flink-io-66f1d0ec-8976-41bf-9575-f80b181b0e47
> at
> sun.nio.fs.UnixFileSystemProvider.implDelete(UnixFileSystemProvider.java:242)
> at
> sun.nio.fs.AbstractFileSystemProvider.delete(AbstractFileSystemProvider.java:103)
> at java.nio.file.Files.delete(Files.java:1126)
> at org.apache.flink.util.FileUtils.deleteDirectory(FileUtils.java:154)
> at
> org.apache.flink.runtime.io.disk.iomanager.IOManager.shutdown(IOManager.java:109)
> at
> org.apache.flink.runtime.io.disk.iomanager.IOManagerAsync.shutdown(IOManagerAsync.java:185)
> at
> org.apache.flink.runtime.taskmanager.TaskManager.postStop(TaskManager.scala:241)
> at akka.actor.Actor$class.aroundPostStop(Actor.scala:477)
> {code}
> Expected:
> * on shutdown delete non-empty directory anyway.
> Notes:
> * after process terminated, I've checked
> "/mnt/flink/tmp/flink-io-66f1d0ec-8976-41bf-9575-f80b181b0e47" directory and
> didn't find anything there. So it looks like timing issue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
