Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4784#discussion_r143407857
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTable.java
 ---
    @@ -448,7 +448,7 @@ public boolean addTask(Task task) throws 
SlotNotFoundException, SlotNotActiveExc
                                throw new 
SlotNotActiveException(task.getJobID(), task.getAllocationId());
                        }
                } else {
    -                   throw new 
SlotNotFoundException(taskSlot.getAllocationId());
    +                   throw new SlotNotFoundException(task.getAllocationId());
    --- End diff --
    
    this is in the else branch of `taskSlot != null`, as in it would always 
fail with a `NullPointerException`. @tillrohrmann 



---

Reply via email to