[
https://issues.apache.org/jira/browse/FLINK-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210241#comment-16210241
]
ASF GitHub Bot commented on FLINK-7758:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4769#discussion_r145565821
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java
---
@@ -543,6 +544,18 @@ private void updateMinPunctuatedWatermark(Watermark
nextWatermark) {
// ------------------------- Metrics ----------------------------------
/**
+ * Register offset metrics.
+ */
+ protected MetricGroup registerOffsetMetrics(MetricGroup metricGroup) {
+ if (useMetrics) {
+ MetricGroup kafkaMetricGroup =
metricGroup.addGroup("KafkaConsumer");
+ addOffsetStateGauge(kafkaMetricGroup);
+ return kafkaMetricGroup;
+ }
+ return new UnregisteredMetricsGroup();
--- End diff --
actually, we could also just return the input metric group.
> Fix bug Kafka09Fetcher add offset metrics
> -------------------------------------------
>
> Key: FLINK-7758
> URL: https://issues.apache.org/jira/browse/FLINK-7758
> Project: Flink
> Issue Type: Bug
> Components: Kafka Connector, Metrics
> Affects Versions: 1.3.2
> Reporter: Hai Zhou UTC+8
> Assignee: Hai Zhou UTC+8
> Fix For: 1.4.0
>
>
> in Kafka09Fetcher, add _KafkaConsumer_ kafkaMetricGroup.
> No judgment that the useMetrics variable is true.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
