[GitHub] flink pull request #4858: [FLINK-7755] [table] Fix NULL handling in batch jo...

[xccui]

Github user xccui commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4858#discussion_r145863086
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/logical/FlinkLogicalJoin.scala
 ---
    @@ -97,8 +97,7 @@ private class FlinkLogicalJoinConverter
     
       private def hasEqualityPredicates(join: LogicalJoin, joinInfo: 
JoinInfo): Boolean = {
    --- End diff --
    
    The parameter `join` seems to be useless now.


---