Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4533#discussion_r146178609
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java
---
@@ -269,4 +315,49 @@ private void decodeBufferOrEvent(RemoteInputChannel
inputChannel, NettyMessage.B
bufferOrEvent.releaseBuffer();
}
}
+
+ private void writeAndFlushNextMessageIfPossible(Channel channel) {
+ if (channelError.get() != null || !channel.isWritable()) {
+ return;
+ }
+
+ while (true) {
+ RemoteInputChannel inputChannel =
inputChannelsWithCredit.poll();
+
+ // The input channel may be null because of the write
callbacks that are executed
+ // after each write, and it is also no need to notify
credit for released channel.
+ if (inputChannel == null || inputChannel.isReleased()) {
+ return;
+ }
+
+ AddCredit msg = new AddCredit(
+ inputChannel.getPartitionId(),
+ inputChannel.getAndResetCredit(),
+ inputChannel.getInputChannelId());
+
+ // Write and flush and wait until this is done before
+ // trying to continue with the next input channel.
+ channel.writeAndFlush(msg).addListener(writeListener);
+
+ return;
--- End diff --
Firsts of all sorry I made a mistake in my previous comment:
> However because `channel.isWritable()` returned true
was supposed to be:
> However because `channel.isWritable()` returned false
> Second, once writeAndFlushNextMessageIfPossible is called, it will loop
all the InputChannel s in the queue until the channel becomes un-writable. Then
the left InputChannel s in the queue will be chosen after the channel becomes
writable again.
Can you point out what code will loop through those `InputChannel`s? Can
you please take a careful look at the `writeAndFlushNextMessageIfPossible`,
especially both exit points from the `while (true)` loop? This code completely
doesn't make sense to me.
```
while (true) { // <<========= ?
RemoteInputChannel inputChannel = inputChannelsWithCredit.poll();
// The input channel may be null because of the write callbacks that
are executed
// after each write, and it is also no need to notify credit for
released channel.
if (inputChannel == null || inputChannel.isReleased()) {
return;
}
(...)
return; // <<========= ?
}
```
---
