Github user xccui commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4813#discussion_r146423916
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
 ---
    @@ -745,12 +748,65 @@ class Table(
         *
         * @param offset number of records to skip
         * @param fetch number of records to be returned
    +    *
    +    * @deprecated Please use [[Table.offset()]] and [[Table.fetch()]] 
instead.
         */
    +  @deprecated(message = "deprecated in favor of Table.offset() and 
Table.fetch()", since = "1.4.0")
       def limit(offset: Int, fetch: Int): Table = {
         new Table(tableEnv, Limit(offset, fetch, 
logicalPlan).validate(tableEnv))
       }
     
       /**
    +    * Limits a sorted result from an offset position.
    +    * Similar to a SQL OFFSET clause. Offset is technically part of the 
Order By operator and
    +    * thus must be preceded by it.
    +    *
    +    * [[Table.offset(o)]] can be combined with a subsequent 
[[Table.fetch(n)]] call to return the
    +    * first n rows starting from the offset position o.
    --- End diff --
    
    If I understand correctly, "from the offset position o" means "from the 
(o+1)th record", right?


---

Reply via email to