[ 
https://issues.apache.org/jira/browse/FLINK-4831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216754#comment-16216754
 ] 

ASF GitHub Bot commented on FLINK-4831:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4661#discussion_r146535744
  
    --- Diff: 
flink-metrics/flink-metrics-slf4j/src/test/resources/log4j-test.properties ---
    @@ -0,0 +1,24 @@
    +#
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#     http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +#
    +
    +log4j.rootLogger=INFO, testlogger
    --- End diff --
    
    This will cause a bit of noise in the logs that I would like to avoid.
    
    Instead, can we, If the log level is configured to OFF, remove all other 
appenders and set it to INFO? This will make the test run without affecting log 
files etc.


> Implement a slf4j metric reporter
> ---------------------------------
>
>                 Key: FLINK-4831
>                 URL: https://issues.apache.org/jira/browse/FLINK-4831
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.1.2
>            Reporter: Chesnay Schepler
>            Assignee: Hai Zhou UTC+8
>            Priority: Minor
>              Labels: easyfix, starter
>             Fix For: 1.4.0
>
>
> For debugging purpose it would be very useful to have a log4j metric 
> reporter. If you don't want to setup a metric backend you currently have to 
> rely on JMX, which a) works a bit differently than other reporters (for 
> example it doesn't extend AbstractReporter) and b) makes it a bit tricky to 
> analyze results as metrics are cleaned up once a job finishes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to