[ 
https://issues.apache.org/jira/browse/FLINK-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220207#comment-16220207
 ] 

ASF GitHub Bot commented on FLINK-5823:
---------------------------------------

Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4907#discussion_r147088825
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java
 ---
    @@ -0,0 +1,68 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.configuration;
    +
    +/**
    + * A collection of all configuration options that relate to checkpoints
    + * and savepoints.
    + */
    +public class CheckpointingOptions {
    +
    +   // 
------------------------------------------------------------------------
    +   //  general checkpoint and state backend options
    +   // 
------------------------------------------------------------------------
    +
    +   public static final ConfigOption<String> STATE_BACKEND = ConfigOptions
    +                   .key("state.backend")
    +                   .noDefaultValue();
    +
    +   /** The maximum number of completed checkpoint instances to retain.*/
    +   public static final ConfigOption<Integer> MAX_RETAINED_CHECKPOINTS = 
ConfigOptions
    +                   .key("state.checkpoints.num-retained")
    +                   .defaultValue(1);
    +
    +   // 
------------------------------------------------------------------------
    +   //  Options specific to the file-system-based state backends
    +   // 
------------------------------------------------------------------------
    +
    +   /** The default directory for savepoints. Used by the state backends 
that write
    +    * savepoints to file systems (MemoryStateBackend, FsStateBackend, 
RocksDBStateBackend). */
    --- End diff --
    
    Yes, the `MemoryStateBackend` actually works for HA and Savepoints. The 
name is misleading...


> Store Checkpoint Root Metadata in StateBackend (not in HA custom store)
> -----------------------------------------------------------------------
>
>                 Key: FLINK-5823
>                 URL: https://issues.apache.org/jira/browse/FLINK-5823
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>            Priority: Blocker
>             Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to