[
https://issues.apache.org/jira/browse/FLINK-7100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220499#comment-16220499
]
Chesnay Schepler commented on FLINK-7100:
-----------------------------------------
We first have to merge FLINK-7876. Unfortunately the PR is in a rather bad
shape imo; it addresses way to many things at once (not separated by commits),
many not even related to the jira (which in fact would deserve their own), and
is built upon another PR that is not necessary for 1.4 (i.e. which means more
review time).
> TaskManager metrics are registered twice
> ----------------------------------------
>
> Key: FLINK-7100
> URL: https://issues.apache.org/jira/browse/FLINK-7100
> Project: Flink
> Issue Type: Bug
> Components: Local Runtime, Metrics
> Affects Versions: 1.3.0, 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Fang Yong
> Priority: Blocker
> Labels: flip-6
> Fix For: 1.4.0, 1.3.3
>
>
> TaskManager metrics are currently registered twice, once when the TaskManager
> is started and once when the TaskManager associates with a JobManager.
> Originally the metrics were registered when the TM associates with the JM and
> unregistered upon disassociation.
> 9e9776f17ed18b12af177e31ab0bc266236f85ef modified the {{TaskManager}} to use
> the {{TaskManagerServices}}, which when loaded _also_ register the metrics.
> I suggest to remove the registrations that happen upon (dis-)association.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
