[
https://issues.apache.org/jira/browse/FLINK-7876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224644#comment-16224644
]
ASF GitHub Bot commented on FLINK-7876:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4872#discussion_r147656394
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
---
@@ -163,12 +156,14 @@ public JobLeaderService getJobLeaderService() {
*
* @param resourceID resource ID of the task manager
* @param taskManagerServicesConfiguration task manager configuration
+ * @param metricRegistry to register the TaskManagerMetricGroup
* @return task manager components
* @throws Exception
*/
public static TaskManagerServices fromConfiguration(
--- End diff --
Seems a bit dirty that the `fromConfiguration` method accepts a
non-configuration object.
> Register TaskManagerMetricGroup under ResourceID instead of InstanceID
> ----------------------------------------------------------------------
>
> Key: FLINK-7876
> URL: https://issues.apache.org/jira/browse/FLINK-7876
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Affects Versions: 1.4.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
> Labels: flip-6
>
> Currently, the {{TaskManager}} registers the {{TaskManagerMetricGroup}} under
> its {{InstanceID}} and thereby binding its metrics effectively to the
> lifetime of its registration with the {{JobManager}}. This has also
> implications how the REST handler retrieve the TaskManager metrics, namely by
> its {{InstanceID}}.
> I would actually propose to register the {{TaskManagerMetricGroup}} under the
> {{TaskManager}}/{{TaskExecutor}} {{ResourceID}} which is valid over the whole
> lifetime of the {{TaskManager}}/{{TaskExecutor}}. That way we would also be
> able to query metrics independent of the connection status to the
> {{JobManager}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
