[ 
https://issues.apache.org/jira/browse/FLINK-7950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225364#comment-16225364
 ] 

ASF GitHub Bot commented on FLINK-7950:
---------------------------------------

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/4925

    [FLINK-7950][build] add flink-queryable-state-runtime as a dependency to 
flink-dist

    ## What is the purpose of the change
    
    Since #4906, `flink-queryable-state-runtime`'s jar file was put into the 
`opt/`
    folder of `flink-dist` and is thus required to build as well.
    
    ## Brief change log
    
    - add `flink-queryable-state-runtime` as a (provided) dependency to 
`flink-dist`
    
    ## Verifying this change
    
    This change can be verified by building the `flink-dist` sub-project: `mvn 
install -pl flink-dist -am` and verifying that it builds as well as that 
`org.apache.flink.queryablestate.client.proxy.KvStateClientProxyHandler` is not 
part of the `flink-dist` uber jar.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (not to Flink 
itself)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-7950

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4925.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4925
    
----

----


> flink-queryable-state-runtime not a dependency in flink-dist
> ------------------------------------------------------------
>
>                 Key: FLINK-7950
>                 URL: https://issues.apache.org/jira/browse/FLINK-7950
>             Project: Flink
>          Issue Type: Bug
>          Components: Build System
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Blocker
>
> {{flink-dist}} requires the {{flink-queryable-state-runtime}} module to be 
> build since FLINK-7824 but this is not set as a dependency in the {{pom.xml}} 
> and thus fails building the sub-project alone, e.g. via {{mvn install -pl 
> flink-dist -am}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to