[ 
https://issues.apache.org/jira/browse/FLINK-7936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226280#comment-16226280
 ] 

Bowen Li commented on FLINK-7936:
---------------------------------

Hi [~pnowojski], does this still hold after your refactor of {{MetricStore}}?

> Lack of synchronization w.r.t. taskManagers in MetricStore#add()
> ----------------------------------------------------------------
>
>                 Key: FLINK-7936
>                 URL: https://issues.apache.org/jira/browse/FLINK-7936
>             Project: Flink
>          Issue Type: Bug
>          Components: Metrics
>            Reporter: Ted Yu
>            Priority: Minor
>
> {code}
>           String tmID = ((QueryScopeInfo.TaskManagerQueryScopeInfo) 
> info).taskManagerID;
>           tm = taskManagers.computeIfAbsent(tmID, k -> new 
> TaskManagerMetricStore());
> {code}
> In other places, access to taskManagers is protected by lock on 
> MetricStore.this



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to