[GitHub] flink pull request #4921: [FLINK-7943] Make ParameterTool thread safe

[tillrohrmann]

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4921#discussion_r148248128
  
    --- Diff: 
flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java 
---
    @@ -454,124 +469,196 @@ public void testUnrequestedDoubleWithMissingValue() 
{
        @Test
        public void testUnrequestedString() {
                ParameterTool parameter = ParameterTool.fromArgs(new 
String[]{"-string", "∞"});
    -           Assert.assertEquals(createHashSet("string"), 
parameter.getUnrequestedParameters());
    +           assertEquals(createHashSet("string"), 
parameter.getUnrequestedParameters());
     
                // test parameter access
    -           Assert.assertEquals("∞", parameter.get("string"));
    -           Assert.assertEquals(Collections.emptySet(), 
parameter.getUnrequestedParameters());
    +           assertEquals("∞", parameter.get("string"));
    +           assertEquals(Collections.emptySet(), 
parameter.getUnrequestedParameters());
     
                // test repeated access
    -           Assert.assertEquals("∞", parameter.get("string"));
    -           Assert.assertEquals(Collections.emptySet(), 
parameter.getUnrequestedParameters());
    +           assertEquals("∞", parameter.get("string"));
    +           assertEquals(Collections.emptySet(), 
parameter.getUnrequestedParameters());
        }
     
        @Test
        public void testUnrequestedStringWithDefaultValue() {
                ParameterTool parameter = ParameterTool.fromArgs(new 
String[]{"-string", "∞"});
    -           Assert.assertEquals(createHashSet("string"), 
parameter.getUnrequestedParameters());
    +           assertEquals(createHashSet("string"), 
parameter.getUnrequestedParameters());
     
                // test parameter access
    -           Assert.assertEquals("∞", parameter.get("string", "0.0"));
    -           Assert.assertEquals(Collections.emptySet(), 
parameter.getUnrequestedParameters());
    +           assertEquals("∞", parameter.get("string", "0.0"));
    +           assertEquals(Collections.emptySet(), 
parameter.getUnrequestedParameters());
     
                // test repeated access
    -           Assert.assertEquals("∞", parameter.get("string", "0.0"));
    -           Assert.assertEquals(Collections.emptySet(), 
parameter.getUnrequestedParameters());
    +           assertEquals("∞", parameter.get("string", "0.0"));
    +           assertEquals(Collections.emptySet(), 
parameter.getUnrequestedParameters());
        }
     
        @Test
        public void testUnrequestedStringWithMissingValue() {
                ParameterTool parameter = ParameterTool.fromArgs(new 
String[]{"-string"});
    -           Assert.assertEquals(createHashSet("string"), 
parameter.getUnrequestedParameters());
    +           assertEquals(createHashSet("string"), 
parameter.getUnrequestedParameters());
     
                parameter.get("string");
    -           Assert.assertEquals(Collections.emptySet(), 
parameter.getUnrequestedParameters());
    +           assertEquals(Collections.emptySet(), 
parameter.getUnrequestedParameters());
        }
     
        // Additional methods
     
        @Test
        public void testUnrequestedHas() {
                ParameterTool parameter = ParameterTool.fromArgs(new 
String[]{"-boolean"});
    -           Assert.assertEquals(createHashSet("boolean"), 
parameter.getUnrequestedParameters());
    +           assertEquals(createHashSet("boolean"), 
parameter.getUnrequestedParameters());
     
                // test parameter access
                Assert.assertTrue(parameter.has("boolean"));
    -           Assert.assertEquals(Collections.emptySet(), 
parameter.getUnrequestedParameters());
    +           assertEquals(Collections.emptySet(), 
parameter.getUnrequestedParameters());
     
                // test repeated access
                Assert.assertTrue(parameter.has("boolean"));
    -           Assert.assertEquals(Collections.emptySet(), 
parameter.getUnrequestedParameters());
    +           assertEquals(Collections.emptySet(), 
parameter.getUnrequestedParameters());
        }
     
        @Test
        public void testUnrequestedRequired() {
                ParameterTool parameter = ParameterTool.fromArgs(new 
String[]{"-required", "∞"});
    -           Assert.assertEquals(createHashSet("required"), 
parameter.getUnrequestedParameters());
    +           assertEquals(createHashSet("required"), 
parameter.getUnrequestedParameters());
     
                // test parameter access
    -           Assert.assertEquals("∞", parameter.getRequired("required"));
    -           Assert.assertEquals(Collections.emptySet(), 
parameter.getUnrequestedParameters());
    +           assertEquals("∞", parameter.getRequired("required"));
    +           assertEquals(Collections.emptySet(), 
parameter.getUnrequestedParameters());
     
                // test repeated access
    -           Assert.assertEquals("∞", parameter.getRequired("required"));
    -           Assert.assertEquals(Collections.emptySet(), 
parameter.getUnrequestedParameters());
    +           assertEquals("∞", parameter.getRequired("required"));
    +           assertEquals(Collections.emptySet(), 
parameter.getUnrequestedParameters());
        }
     
        @Test
        public void testUnrequestedMultiple() {
                ParameterTool parameter = ParameterTool.fromArgs(new 
String[]{"-boolean", "true", "-byte", "1",
                        "-short", "2", "-int", "4", "-long", "8", "-float", 
"4.0", "-double", "8.0", "-string", "∞"});
    -           Assert.assertEquals(createHashSet("boolean", "byte", "short", 
"int", "long", "float", "double", "string"),
    +           assertEquals(createHashSet("boolean", "byte", "short", "int", 
"long", "float", "double", "string"),
                        parameter.getUnrequestedParameters());
     
                Assert.assertTrue(parameter.getBoolean("boolean"));
    -           Assert.assertEquals(createHashSet("byte", "short", "int", 
"long", "float", "double", "string"),
    +           assertEquals(createHashSet("byte", "short", "int", "long", 
"float", "double", "string"),
                        parameter.getUnrequestedParameters());
     
    -           Assert.assertEquals(1, parameter.getByte("byte"));
    -           Assert.assertEquals(createHashSet("short", "int", "long", 
"float", "double", "string"),
    +           assertEquals(1, parameter.getByte("byte"));
    +           assertEquals(createHashSet("short", "int", "long", "float", 
"double", "string"),
                        parameter.getUnrequestedParameters());
     
    -           Assert.assertEquals(2, parameter.getShort("short"));
    -           Assert.assertEquals(createHashSet("int", "long", "float", 
"double", "string"),
    +           assertEquals(2, parameter.getShort("short"));
    +           assertEquals(createHashSet("int", "long", "float", "double", 
"string"),
                        parameter.getUnrequestedParameters());
     
    -           Assert.assertEquals(4, parameter.getInt("int"));
    -           Assert.assertEquals(createHashSet("long", "float", "double", 
"string"),
    +           assertEquals(4, parameter.getInt("int"));
    +           assertEquals(createHashSet("long", "float", "double", "string"),
                        parameter.getUnrequestedParameters());
     
    -           Assert.assertEquals(8, parameter.getLong("long"));
    -           Assert.assertEquals(createHashSet("float", "double", "string"),
    +           assertEquals(8, parameter.getLong("long"));
    +           assertEquals(createHashSet("float", "double", "string"),
                        parameter.getUnrequestedParameters());
     
    -           Assert.assertEquals(4.0, parameter.getFloat("float"), 0.00001);
    -           Assert.assertEquals(createHashSet("double", "string"),
    +           assertEquals(4.0, parameter.getFloat("float"), 0.00001);
    +           assertEquals(createHashSet("double", "string"),
                        parameter.getUnrequestedParameters());
     
    -           Assert.assertEquals(8.0, parameter.getDouble("double"), 
0.00001);
    -           Assert.assertEquals(createHashSet("string"),
    --- End diff --
    
    True, I guess that was done due to auto reformatting when writing the 
`testConcurrentExecutionConfigSerialization`.


---