Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4933#discussion_r148305773
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/utils/SimpleAckingTaskManagerGateway.java
 ---
    @@ -48,6 +48,8 @@
     
        private Optional<Consumer<ExecutionAttemptID>> optSubmitCondition;
     
    +   private Optional<Consumer<ExecutionAttemptID>> optCancelCondition;
    --- End diff --
    
    This will be always `null` initialized. Isn't that a problem?


---

Reply via email to