Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4887#discussion_r148552085
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/ResourceActions.java
 ---
    @@ -52,4 +52,6 @@
         * @param cause of the allocation failure
         */
        void notifyAllocationFailure(JobID jobId, AllocationID allocationId, 
Exception cause);
    +
    +   void cancelResourceAllocation(ResourceProfile resourceProfile);
    --- End diff --
    
    I think we don't necessarily need this call. See my comment in the 
`SlotManager`.


---

Reply via email to