[ https://issues.apache.org/jira/browse/FLINK-6434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236191#comment-16236191 ]
ASF GitHub Bot commented on FLINK-6434: --------------------------------------- Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4937#discussion_r148599674 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/instance/SlotPoolGateway.java --- @@ -86,10 +85,16 @@ // ------------------------------------------------------------------------ CompletableFuture<SimpleSlot> allocateSlot( - ScheduledUnit task, + AllocationID allocationID, ResourceProfile resources, Iterable<TaskManagerLocation> locationPreferences, @RpcTimeout Time timeout); void returnAllocatedSlot(Slot slot); + + /** + * Cancel a slot allocation. + * This method should be called when the CompletableFuture returned by allocateSlot completed exceptionally. --- End diff -- Params description is missing. > There may be allocatedSlots leak in SlotPool > -------------------------------------------- > > Key: FLINK-6434 > URL: https://issues.apache.org/jira/browse/FLINK-6434 > Project: Flink > Issue Type: Bug > Components: Cluster Management > Reporter: shuai.xu > Assignee: shuai.xu > Priority: Major > Labels: flip-6 > > If the call allocateSlot() from Execution to Slotpool timeout, the job will > begin to failover, but the pending request are still in SlotPool, if then a > new slot register to SlotPool, it may be fulfill the outdated pending request > and be added to allocatedSlots, but it will never be used and will never be > recycled. -- This message was sent by Atlassian JIRA (v6.4.14#64029)