[ 
https://issues.apache.org/jira/browse/FLINK-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236249#comment-16236249
 ] 

ASF GitHub Bot commented on FLINK-7694:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4757#discussion_r148606524
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/metrics/JobMetricsHandlerTest.java
 ---
    @@ -50,10 +50,10 @@ public void testGetPaths() {
        @Test
        public void getMapFor() throws Exception {
                MetricFetcher fetcher = new MetricFetcher(
    -                   mock(GatewayRetriever.class),
    -                   mock(MetricQueryServiceRetriever.class),
    -                   Executors.directExecutor(),
    -                   TestingUtils.TIMEOUT());
    +                                                                           
mock(GatewayRetriever.class),
    +                                                                           
mock(MetricQueryServiceRetriever.class),
    +                                                                           
Executors.directExecutor(),
    +                                                                           
TestingUtils.TIMEOUT());
    --- End diff --
    
    Please revert


> Port JobMetricsHandler to new REST handler
> ------------------------------------------
>
>                 Key: FLINK-7694
>                 URL: https://issues.apache.org/jira/browse/FLINK-7694
>             Project: Flink
>          Issue Type: Sub-task
>          Components: REST, Webfrontend
>            Reporter: Bowen Li
>            Assignee: Bowen Li
>            Priority: Major
>             Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to