[GitHub] flink pull request #4939: [FLINK-4228][yarn/s3a] fix yarn resource upload s3...

[tillrohrmann]

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4939#discussion_r149069107
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
 ---
    @@ -705,11 +707,12 @@ public ApplicationReport startAppMaster(
                StringBuilder envShipFileList = new StringBuilder();
     
                // upload and register ship files
    -           List<String> systemClassPaths = 
uploadAndRegisterFiles(systemShipFiles, fs, appId.toString(), paths, 
localResources, envShipFileList);
    +           List<String> systemClassPaths = 
uploadAndRegisterFiles(systemShipFiles, fs,
    +                   homeDir, appId, paths, localResources, envShipFileList);
    --- End diff --
    
    nit: I would either not break lines or break after each argument.


---