[
https://issues.apache.org/jira/browse/FLINK-7746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16240279#comment-16240279
]
ASF GitHub Bot commented on FLINK-7746:
---------------------------------------
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4759
I'm wondering whether we should actually merge this commit without the
actual removal of the `ResultPartitionWriter`. Currently, this change does not
really adds much value a part from introducing an additional level of
indirection in the `ResultPartitionWriter`. Therefore, I would propose to merge
this commit with the actual `ResultPartitionWriter` removal.
> move ResultPartitionWriter#writeBufferToAllChannels up into ResultPartition
> ---------------------------------------------------------------------------
>
> Key: FLINK-7746
> URL: https://issues.apache.org/jira/browse/FLINK-7746
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
>
> As a step towards removing the (unneeded) {{ResultPartitionWriter}} wrapper,
> we should move {{ResultPartitionWriter#writeBufferToAllChannels}} into
> {{ResultPartition}} where single-channel writing happens anyway.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
