[
https://issues.apache.org/jira/browse/FLINK-7515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16240281#comment-16240281
]
ASF GitHub Bot commented on FLINK-7515:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4592#discussion_r149077193
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
---
@@ -67,12 +68,53 @@
//
------------------------------------------------------------------------
+ /**
+ * Allocates a new (header and contents) buffer and adds some header
information for the frame
--- End diff --
This method only allocates memory for the header and no contents (or
contents is empty). Maybe we could update the JavaDoc accordingly.
> allow actual 0-length content in NettyMessage#allocateBuffer()
> --------------------------------------------------------------
>
> Key: FLINK-7515
> URL: https://issues.apache.org/jira/browse/FLINK-7515
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Affects Versions: 1.4.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Minor
>
> Previously, length {{0}} meant "unknown content length" but there are cases
> where the actual length is 0 and we do not need a larger buffer. Let's use
> {{-1}} for tagging the special case instead.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
