Github user thvasilo commented on the pull request:

    https://github.com/apache/flink/pull/772#issuecomment-114117337
  
    OK so as I understand it this PR is about splitting the prediction with 
Vector and LabeledVector input into two functions instead of one as it is now.
    
    This allows us to avoid some code duplication and have better defined 
semantics. I'm fine with that.
    
    I would change the name from *Evaluate* and *evaluation* to something 
different though. Evaluation for me means making predictions *and* evaluating 
the result using some aggregating metric. The result of an evaluation should be 
a score (real number).
    
    Something like labeledPrediction or predictLabeled makes more sense. Any 
other suggestions?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to