[
https://issues.apache.org/jira/browse/FLINK-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14595956#comment-14595956
]
ASF GitHub Bot commented on FLINK-2116:
---------------------------------------
Github user thvasilo commented on the pull request:
https://github.com/apache/flink/pull/772#issuecomment-114117337
OK so as I understand it this PR is about splitting the prediction with
Vector and LabeledVector input into two functions instead of one as it is now.
This allows us to avoid some code duplication and have better defined
semantics. I'm fine with that.
I would change the name from *Evaluate* and *evaluation* to something
different though. Evaluation for me means making predictions *and* evaluating
the result using some aggregating metric. The result of an evaluation should be
a score (real number).
Something like labeledPrediction or predictLabeled makes more sense. Any
other suggestions?
> Make pipeline extension require less coding
> -------------------------------------------
>
> Key: FLINK-2116
> URL: https://issues.apache.org/jira/browse/FLINK-2116
> Project: Flink
> Issue Type: Improvement
> Components: Machine Learning Library
> Reporter: Mikio Braun
> Assignee: Till Rohrmann
> Priority: Minor
>
> Right now, implementing methods from the pipelines for new types, or even
> adding new methods to pipelines requires many steps:
> 1) implementing methods for new types
> implement implicit of the corresponding class encapsulating the operation
> in the companion object
> 2) adding methods to the pipeline
> - adding a method
> - adding a trait for the operation
> - implement implicit in the companion object
> These are all objects which contain many generic parameters, so reducing the
> work would be great.
> The goal should be that you can really focus on the code to add, and have as
> little boilerplate code as possible.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
