Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4993#discussion_r150222505
--- Diff:
flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerBase.java
---
@@ -250,8 +252,8 @@ private boolean attemptToBind(final int port) throws
Throwable {
throw future.cause();
} catch (BindException e) {
- LOG.debug("Failed to start server {} on port {}: {}.",
serverName, port, e.getMessage());
- shutdown();
+ log.debug("Failed to start {} on port {}: {}.",
serverName, port, e.getMessage());
+ shutdownServer(Time.seconds(10L)).join();
--- End diff --
I would use `get()` because it makes the thrown exceptions explicit.
---
