[
https://issues.apache.org/jira/browse/FLINK-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251532#comment-16251532
]
ASF GitHub Bot commented on FLINK-8071:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5014
[FLINK-8071][build] Bump shade-plugin asm version to 5.1
## What is the purpose of the change
This PR bumps the ASM dependency of the `maven-shade-plugin` to 5.1 as a
workaround to a bug in ASM. This bug causes some error during the shading of
akka, making it unusable.
## Verifying this change
I can't guarantee 100% that this fixes the issue, since the shading issue
only manifests sometimes. This means a simple recompilation of flink-runtime
_can_ resolve the issue temporarily.
I've compiled flink-runtime, flink-dist and ran the flink-yarn-tests in a
loop and switched the version bump on and off. It only failed with the old ASM
version,
To verify that the `maven-shade-plugin` uses ASM 5.1, run `mvn -X package`
in an arbitrary module and check the dependency tree.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 8071
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5014.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5014
----
commit 2544cc4078e85673767e8d2ff1a5966f0b07baa7
Author: zentol <ches...@apache.org>
Date: 2017-11-14T13:47:00Z
[FLINK-8071][build] Bump shade-plugin asm version to 5.1
----
> Akka shading sometimes produces invalid code
> --------------------------------------------
>
> Key: FLINK-8071
> URL: https://issues.apache.org/jira/browse/FLINK-8071
> Project: Flink
> Issue Type: Bug
> Components: Build System, Local Runtime
> Affects Versions: 1.4.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Blocker
> Fix For: 1.4.0
>
>
> On 2 separate occasions on separate machines I hit the exception below when
> starting a cluster. Once it happened in the yarn tests, another time after
> starting a standalone cluster with flink-dist.
> The issue appears to be related to some asm bug that affects both
> sbt-assembly and the maven-shade-plugin.
> References:
> * https://github.com/akka/akka/issues/21596
> * https://github.com/sbt/sbt-assembly/issues/205
> From what I have found this should be fixable my bumping the asm version of
> the maven-shade-plugin to 5.1 (out version uses 5.0.2), or just increment the
> plugin version to 3.0.0 (which already uses 5.1).
> {code}
> java.lang.Exception: Could not create actor system
> at
> org.apache.flink.runtime.clusterframework.BootstrapTools.startActorSystem(BootstrapTools.java:171)
> at
> org.apache.flink.runtime.clusterframework.BootstrapTools.startActorSystem(BootstrapTools.java:115)
> at
> org.apache.flink.yarn.YarnApplicationMasterRunner.runApplicationMaster(YarnApplicationMasterRunner.java:313)
> at
> org.apache.flink.yarn.YarnApplicationMasterRunner$1.call(YarnApplicationMasterRunner.java:199)
> at
> org.apache.flink.yarn.YarnApplicationMasterRunner$1.call(YarnApplicationMasterRunner.java:196)
> at java.security.AccessController.doPrivileged(Native Method)
> at javax.security.auth.Subject.doAs(Subject.java:422)
> at
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1556)
> at
> org.apache.flink.runtime.security.HadoopSecurityContext.runSecured(HadoopSecurityContext.java:41)
> at
> org.apache.flink.yarn.YarnApplicationMasterRunner.run(YarnApplicationMasterRunner.java:196)
> at
> org.apache.flink.yarn.YarnApplicationMasterRunner.main(YarnApplicationMasterRunner.java:123)
> Caused by: java.lang.VerifyError: Inconsistent stackmap frames at branch
> target 152
> Exception Details:
> Location:
> akka/dispatch/Mailbox.processAllSystemMessages()V @152: getstatic
> Reason:
> Type top (current frame, locals[9]) is not assignable to
> 'akka/dispatch/sysmsg/SystemMessage' (stack map, locals[9])
> Current Frame:
> bci: @131
> flags: { }
> locals: { 'akka/dispatch/Mailbox', 'java/lang/InterruptedException',
> 'akka/dispatch/sysmsg/SystemMessage', top, 'akka/dispatch/Mailbox',
> 'java/lang/Throwable', 'java/lang/Throwable' }
> stack: { integer }
> Stackmap Frame:
> bci: @152
> flags: { }
> locals: { 'akka/dispatch/Mailbox', 'java/lang/InterruptedException',
> 'akka/dispatch/sysmsg/SystemMessage', top, 'akka/dispatch/Mailbox',
> 'java/lang/Throwable', 'java/lang/Throwable', top, top,
> 'akka/dispatch/sysmsg/SystemMessage' }
> stack: { }
> Bytecode:
> 0x0000000: 014c 2ab2 0132 b601 35b6 0139 4db2 013e
> 0x0000010: 2cb6 0142 9900 522a b600 c69a 004b 2c4e
> 0x0000020: b201 3e2c b601 454d 2db9 0148 0100 2ab6
> 0x0000030: 0052 2db6 014b b801 0999 000e bb00 e759
> 0x0000040: 1301 4db7 010f 4cb2 013e 2cb6 0150 99ff
> 0x0000050: bf2a b600 c69a ffb8 2ab2 0132 b601 35b6
> 0x0000060: 0139 4da7 ffaa 2ab6 0052 b600 56b6 0154
> 0x0000070: b601 5a3a 04a7 0091 3a05 1905 3a06 1906
> 0x0000080: c100 e799 0015 1906 c000 e73a 0719 074c
> 0x0000090: b200 f63a 08a7 0071 b201 5f19 06b6 0163
> 0x00000a0: 3a0a 190a b601 6899 0006 1905 bf19 0ab6
> 0x00000b0: 016c c000 df3a 0b2a b600 52b6 0170 b601
> 0x00000c0: 76bb 000f 5919 0b2a b600 52b6 017a b601
> 0x00000d0: 80b6 0186 2ab6 018a bb01 8c59 b701 8e13
> 0x00000e0: 0190 b601 9419 09b6 0194 1301 96b6 0194
> 0x00000f0: 190b b601 99b6 0194 b601 9ab7 019d b601
> 0x0000100: a3b2 00f6 3a08 b201 3e2c b601 4299 0026
> 0x0000110: 2c3a 09b2 013e 2cb6 0145 4d19 09b9 0148
> 0x0000120: 0100 1904 2ab6 0052 b601 7a19 09b6 01a7
> 0x0000130: a7ff d62b c600 09b8 0109 572b bfb1
> Exception Handler Table:
> bci [290, 307] => handler: 120
> Stackmap Table:
> append_frame(@13,Object[#231],Object[#177])
> append_frame(@71,Object[#177])
> chop_frame(@102,1)
>
> full_frame(@120,{Object[#2],Object[#231],Object[#177],Top,Object[#2],Object[#177]},{Object[#223]})
>
> full_frame(@152,{Object[#2],Object[#231],Object[#177],Top,Object[#2],Object[#223],Object[#223],Top,Top,Object[#177]},{})
> append_frame(@173,Object[#357])
> full_frame(@262,{Object[#2],Object[#231],Object[#177],Top,Object[#2]},{})
> same_frame(@307)
> same_frame(@317)
> at akka.dispatch.Mailboxes.<init>(Mailboxes.scala:33)
> at akka.actor.ActorSystemImpl.<init>(ActorSystem.scala:800)
> at akka.actor.ActorSystem$.apply(ActorSystem.scala:245)
> at akka.actor.ActorSystem$.apply(ActorSystem.scala:288)
> at akka.actor.ActorSystem$.apply(ActorSystem.scala:263)
> at akka.actor.ActorSystem$.create(ActorSystem.scala:191)
> at
> org.apache.flink.runtime.akka.AkkaUtils$.createActorSystem(AkkaUtils.scala:106)
> at
> org.apache.flink.runtime.akka.AkkaUtils.createActorSystem(AkkaUtils.scala)
> at
> org.apache.flink.runtime.clusterframework.BootstrapTools.startActorSystem(BootstrapTools.java:158)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
