[ 
https://issues.apache.org/jira/browse/FLINK-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597376#comment-14597376
 ] 

ASF GitHub Bot commented on FLINK-1962:
---------------------------------------

Github user aljoscha commented on the pull request:

    https://github.com/apache/flink/pull/808#issuecomment-114412170
  
    ExecutionEnvironment.scala, UnionOperator.java and Graph.java have a lot of 
whitespace/formatting changes. This makes it hard to see the actual changes to 
functionality.
    
    None of the methods in the new Scala code have comments/Scaladoc. 
Especially the methods on Graph.scala, these should have documentation, similar 
to the methods on Graph.java.
    
    Other than that, this looks good. I especially like that basically half of 
the new files are test cases. :+1: 
    
    Could someone from the Graph side ( @vasia, @andralungu ) please chime in 
on this.


> Add Gelly Scala API
> -------------------
>
>                 Key: FLINK-1962
>                 URL: https://issues.apache.org/jira/browse/FLINK-1962
>             Project: Flink
>          Issue Type: Task
>          Components: Gelly, Scala API
>    Affects Versions: 0.9
>            Reporter: Vasia Kalavri
>            Assignee: PJ Van Aeken
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to