[
https://issues.apache.org/jira/browse/FLINK-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259929#comment-16259929
]
ASF GitHub Bot commented on FLINK-8104:
---------------------------------------
GitHub user walterddr opened a pull request:
https://github.com/apache/flink/pull/5040
[FLINK-8104][Table API] fixing ROW type value constructor for SQL API.
## What is the purpose of the change
Supports creation of a ROW based on fields or literals. such as:
`ROW('hello', 12, true)` or simply `('hello', 12, true)`.
## Brief change log
- Added in `generateRow` for Row type generation
- Fix FlinkTypeFactory not able to recognize `RelRecordType` by resolving
it through `RowSchema` class.
## Verifying this change
This change added tests and can be verified as follows:
- Added unit test for SQL expression and integration test for value
constructor
## Does this pull request potentially affect one of the following parts:
No
## Documentation
- Does this pull request introduce a new feature? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/walterddr/flink FLINK-8104
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5040.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5040
----
commit 9909ad1b8abed74964b2fce1025ad3503b5abf98
Author: Rong Rong <ro...@uber.com>
Date: 2017-11-20T21:47:50Z
fixing ROW type value constructor for SQL API. Supports creation of a ROW
based on fields or literals
----
> Fix Row value constructor
> -------------------------
>
> Key: FLINK-8104
> URL: https://issues.apache.org/jira/browse/FLINK-8104
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Rong Rong
> Assignee: Rong Rong
>
> Support Row value constructor which is currently broken.
> See
> {code:java}
> //
> flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/SqlExpressionTest.scala
> @Test
> def testValueConstructorFunctions(): Unit = {
> // TODO we need a special code path that flattens ROW types
> // testSqlApi("ROW('hello world', 12)", "hello world") // test base only
> returns field 0
> // testSqlApi("('hello world', 12)", "hello world") // test base only
> returns field 0
> // ...
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
