Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5069#discussion_r153139738
  
    --- Diff: 
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
 ---
    @@ -41,7 +42,6 @@
     import 
org.apache.flink.streaming.connectors.kinesis.serialization.KinesisDeserializationSchema;
     import 
org.apache.flink.streaming.connectors.kinesis.serialization.KinesisDeserializationSchemaWrapper;
     import 
org.apache.flink.streaming.connectors.kinesis.util.KinesisConfigUtil;
    -import org.apache.flink.streaming.util.serialization.DeserializationSchema;
    --- End diff --
    
    I think we can not simply remove the usage of this, as that will be an user 
API-breaking change (for users that use the `FlinkKinesisConsumer(String, 
DeserializationSchema<T>, Properties)` constructor).
    
    Instead of removing this, we should deprecate the constructors that accept 
the deprecated `DeserializationSchema` interface, and add new corresponding 
constructors that accept the new migrated `DeserializationSchema`.


---

Reply via email to