Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/5050#discussion_r153141260
--- Diff:
flink-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/PeriodicOffsetCommitter.java
---
@@ -45,14 +45,18 @@
/** Flag to mark the periodic committer as running. */
private volatile boolean running = true;
+ /** The task info to register in zk ownership path. */
+ private final String taskId;
+
PeriodicOffsetCommitter(ZookeeperOffsetHandler offsetHandler,
List<KafkaTopicPartitionState<TopicAndPartition>>
partitionStates,
ExceptionProxy errorHandler,
- long commitInterval) {
+ long commitInterval, String taskId) {
--- End diff --
Please list this parameter on a separate new line for consistently code
style.
---
