Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/5074#discussion_r153234962
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
---
@@ -190,6 +199,11 @@ public static TaskManagerServices fromConfiguration(
final JobLeaderService jobLeaderService = new
JobLeaderService(taskManagerLocation);
+ final CheckpointCacheManager checkpointCacheManager = new
CheckpointCacheManager(
+ new ScheduledThreadPoolExecutor(1),
+ Executors.directExecutor(),
+ taskManagerServicesConfiguration.getTmpDirPaths()[0]);
--- End diff --
I find this problematic, because it does not consider all the configured
tmp directories. While most user probably have only a single tmp directory
configured, this can be problematic if somebody makes use of multiple
directories (e.g. to utilize multiple smaller disks). We should also be
sensitive about this case.
---
