[ 
https://issues.apache.org/jira/browse/FLINK-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14601092#comment-14601092
 ] 

ASF GitHub Bot commented on FLINK-2230:
---------------------------------------

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/867#issuecomment-115227753
  
    We actually had a discussion about this quite a few times. I also raised my 
concerns in the discussion of the issue, to which no one reacted. 
    
    The serialization subsystem (and tuples) are of the most critical nature in 
Flink. There are so many side effects and considerations. Comparators that 
interact with serializers, normalized keys, subclasses and tagging, object 
creation (GC impact). None of that is taken into account here.
    
    For something as crucial as this, we cannot make changes without being 
discussed thoroughly before, and at best, also documented. It makes sense to do 
this before the code writing.
    
    Sorry if I appear like the bad guy here. But we are at the verge of getting 
into spaghetti code and inconsistencies in one of the most crucial parts, and 
we cannot do that.


> Add Support for Null-Values in TupleSerializer
> ----------------------------------------------
>
>                 Key: FLINK-2230
>                 URL: https://issues.apache.org/jira/browse/FLINK-2230
>             Project: Flink
>          Issue Type: Sub-task
>            Reporter: Shiti Saxena
>            Assignee: Shiti Saxena
>            Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to