[ 
https://issues.apache.org/jira/browse/FLINK-7907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272465#comment-16272465
 ] 

ASF GitHub Bot commented on FLINK-7907:
---------------------------------------

Github user yew1eb commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5071#discussion_r154031899
  
    --- Diff: docs/monitoring/metrics.md ---
    @@ -94,8 +94,8 @@ Alternatively you can also use your own `Counter` 
implementation:
     <div data-lang="java" markdown="1">
     {% highlight java %}
     
    -public class MyMapper extends RichMapFunction<String, String> {
    -  private Counter counter;
    +RichMapFunction<String, String> {
    --- End diff --
    
    Now this PR has been updated, please look at it again.



> Flink Metrics documentation missing Scala examples
> --------------------------------------------------
>
>                 Key: FLINK-7907
>                 URL: https://issues.apache.org/jira/browse/FLINK-7907
>             Project: Flink
>          Issue Type: Improvement
>          Components: Documentation
>            Reporter: Colin Williams
>            Assignee: Hai Zhou UTC+8
>            Priority: Minor
>
> The Flink metrics documentation is missing Scala examples for many of the 
> metrics types. To be consistent there should be Scala examples for all the 
> types.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to