Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4761#discussion_r154067761
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/ResultPartitionWriter.java
 ---
    @@ -34,12 +31,10 @@
      * The {@link ResultPartitionWriter} is the runtime API for producing 
results. It
      * supports two kinds of data to be sent: buffers and events.
      */
    -public class ResultPartitionWriter implements EventListener<TaskEvent> {
    --- End diff --
    
    a quick search reveals `NetworkEnvironment.java` calling 
`taskEventDispatcher.registerWriterForIncomingTaskEvents(writer.getPartitionId(),
 writer);` and therefore `TaskEventDispatcher` itself but there, the 
`EventListener` interface was actually only used in 
`TaskEventDispatcher#publish()` which is somewhat strange - agreed


---

Reply via email to